mistercrunch commented on a change in pull request #11603:
URL:
https://github.com/apache/incubator-superset/pull/11603#discussion_r519198218
##########
File path: tox.ini
##########
@@ -44,56 +46,79 @@ setenv =
# make sure that directory is accessible by docker
hive: UPLOAD_FOLDER = /tmp/.superset/app/static/uploads/
usedevelop = true
-whitelist_externals =
+allowlist_externals =
npm
+ pkill
-[testenv:cypress-dashboard]
+[testenv:cypress]
+setenv =
+ PYTHONPATH = {toxinidir}
+ SUPERSET_TESTENV = true
+ SUPERSET_CONFIG = tests.superset_test_config
+ SUPERSET_HOME = {envtmpdir}
+ ENABLE_REACT_CRUD_VIEWS = true
commands =
npm install -g npm@'>=6.5.0'
pip install -e {toxinidir}/
- {toxinidir}/superset-frontend/cypress_build.sh dashboard
-deps =
- -rrequirements/testing.txt
+ {toxinidir}/superset-frontend/cypress_build.sh
+commands_post =
+ pkill -if "python {envbindir}/flask"
+
+[testenv:cypress-dashboard]
Review comment:
Oh interesting, we still have the tox envs split up as 3 different suite
(we use to run 3 cells in Travis), but on GitHub actions we're running it
inside a single cell inside the build matrix. This means that these touchups
here aren't validated by CI. Personally I haven't been using `tox` locally for
e2e/cypress, and have no sense as to whether people use this layer.
NOTE: We discussed in the past whether we want to commit or break away from
`tox` as a way to run local tests. But that matter is outside the scope of this
PR!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
