graceguo-supercat opened a new pull request #11614: URL: https://github.com/apache/incubator-superset/pull/11614
### SUMMARY In #11220 and #11305, we introduced a feature that prevent mid-air collision when 2 users editing same dashboard. There are some users in airbnb reported that when only 1 user editing dashboard a couple of times they will see the warning message, even there is no co-editing happens, see issue #11477 When i debug this issue, i found when error happens, it shows client-side last_updated_time and dashboard's changed_on has a very subtle mis-match, for example: ``` remote:1604869261.688 changed_on:1604869262.0 ``` it seems dashboards table's changed_on has round-up to second level, while client-side last_update_time is not. So i will add a round function in client-side and try to make this number match in the second level. ### TEST PLAN CI and manual test ### ADDITIONAL INFORMATION <!--- Check any relevant boxes with "x" --> <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue --> - [x] Has associated issue: #11220 and #11305 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
