newtoncy opened a new pull request #11615:
URL: https://github.com/apache/incubator-superset/pull/11615


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   Treemap cannot be nested more than three levels before I modify it.
   If the nesting is more than three levels, keyerror will be raised.
   The unit tests I added can replicate this problem.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   Create a new chart
   
   Select tree map
   
   Select at least three dimensions in group by, and each dimension has at 
least two cardinalities
   
   Run this query
   
   This will trigger a keyerror before I modify it.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to