eschutho commented on pull request #11289: URL: https://github.com/apache/incubator-superset/pull/11289#issuecomment-724304150
>For Groupby and Columns control, number of available options reduces after users selected columns as the same column cannot be selected twice. But the place holder still says x options where x is the initial number of options. That's a great point. I'll look into that. Thx! Also, @suddjian and I were looking at the type assertion on value and made a small tweak to `isMulti && Array.isArray(value) && value.length` instead, and thought it read a little better. I made that update, so LMK any thoughts on that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
