[GitHub] [incubator-superset] ktmud opened a new pull request #11626: feat(sankey-viz): allow sort by metric

[GitBox]

ktmud opened a new pull request #11626:
URL: https://github.com/apache/incubator-superset/pull/11626


   ### SUMMARY
   
   Adding a "Sort by metric" checkbox control for Sankey chart. If selected, 
the query results will be sorted by metric in descending order. This is useful 
when there are many rows of data but it's not easy to regroup source and 
targets via custom SQL queries (e.g. when working with a datasource that does 
not support arbitrary SQL queries).
   
   <img 
src="https://user-images.githubusercontent.com/335541/98601024-4c441800-2293-11eb-8225-2708be52f2b4.png";
 width="300">
   
   Also added a caveat warning for row limit:
   
   <img 
src="https://user-images.githubusercontent.com/335541/98601030-4f3f0880-2293-11eb-903e-461cd6b7b428.png";
 width="300">
   
   ### TEST PLAN
   
   Manual 
   
   1. Go to a sankey chart
   2. Set row limit to a small number
   3. Toggle SORT BY METRIC and rerun the query
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: 
https://github.com/apache-superset/superset-ui/pull/831
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org