robdiciuccio commented on a change in pull request #11498:
URL:
https://github.com/apache/incubator-superset/pull/11498#discussion_r520724052
##########
File path: superset-websocket/client-ws-app/public/javascripts/app.js
##########
@@ -0,0 +1,42 @@
+console.log('hello');
+let socketCount = 0;
+let messageCount = 0;
+
+const jwtSecret = "test-secret-change-me";
Review comment:
This should read from the same config file as the main app, which still
needs to be moved out of version control. The `client-ws-app` is not meant to
be used in production, only for testing; I'll improve the packaging and
documentation to make that clear.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
