etr2460 commented on a change in pull request #11626:
URL:
https://github.com/apache/incubator-superset/pull/11626#discussion_r520943825
##########
File path: superset/viz.py
##########
@@ -1854,6 +1854,8 @@ def query_obj(self) -> QueryObjectDict:
_("Pick exactly 2 columns as [Source / Target]")
)
qry["metrics"] = [self.form_data["metric"]]
+ if self.form_data.get("sort_by_metric", False):
Review comment:
you don't need the False here, it'll default to None which is falsey
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
