eschutho commented on a change in pull request #11603: URL: https://github.com/apache/incubator-superset/pull/11603#discussion_r518931663
########## File path: CONTRIBUTING.md ########## @@ -624,32 +624,36 @@ We use [Cypress](https://www.cypress.io/) for integration tests. Tests can be ru ```bash export SUPERSET_CONFIG=tests.superset_test_config +export SUPERSET_TESTENV=true +export ENABLE_REACT_CRUD_VIEWS=true export CYPRESS_BASE_URL="http://localhost:8081"; Review comment: one piece of feedback that Harrison gave on this, is that this `export CYPRESS_BASE_URL` needs to be run in the same shell window as the cypress command. Should we move this line down, or else put it on the same line, such as `CYPRESS_BASE_URL="http://localhost:8081"; npm run cypress-run-chrome` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
