eschutho commented on pull request #11289: URL: https://github.com/apache/incubator-superset/pull/11289#issuecomment-725045323
Thank you both for that feedback. I removed "select all" from the count. @ktmud my understanding of react-select is that it will calculate the options to show if `isMulti` and there is no `filterOption` method passed to the component by removing the value selected from the option list, but it doesn't not expose that value back to us. Because of this abstraction of the select values, I am calculating what is left by subtracting total selected values from total options. But in the case where we have a `filterOption` method that allows you to select an option twice, in the case of metrics or filters, this method won't work. But of course without evaluating the `filterOption` passed in, we won't know what it does. It seems to me that there aren't any filters that are using `SelectControl` that behaves in this way, but it still feels a bit brittle. Do you think this would work in this case or have other suggestions? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
