mistercrunch commented on a change in pull request #11615:
URL:
https://github.com/apache/incubator-superset/pull/11615#discussion_r521471323
##########
File path: superset/viz.py
##########
@@ -972,9 +972,10 @@ def _nest(self, metric: str, df: pd.DataFrame) ->
List[Dict[str, Any]]:
if nlevels == 1:
result = [{"name": n, "value": v} for n, v in zip(df.index,
df[metric])]
else:
+ this_level_index = {i[0] for i in df.index}
Review comment:
Should this be a `set` or a `list`? Sets don't preserve ordering,
without full context, it feels like ordering may matter here (?)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
