tswast commented on a change in pull request #11660:
URL:
https://github.com/apache/incubator-superset/pull/11660#discussion_r521686961
##########
File path: superset/sql_lab.py
##########
@@ -353,9 +354,16 @@ def execute_sql_statements( # pylint:
disable=too-many-arguments, too-many-loca
logger.info("Query %s: %s", str(query_id), msg)
query.set_extra_json_key("progress", msg)
session.commit()
Review comment:
Does this call `commit` on the `cursor`? I was thinking in
https://github.com/googleapis/python-bigquery/issues/377 that we'd flush any
batched queries when a `commit` was called, but it sounds like this may also
not be desirable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
