graceguo-supercat opened a new pull request #11661: URL: https://github.com/apache/incubator-superset/pull/11661
### SUMMARY We found an issue when user tried to change default filter value for a dashboard: 1. from dashboard list, user open a dashboard. current dashboard url contains default filters in the url: for example: http://localhost:8080/superset/dashboard/67/?preselect_filters=%7B"1086"%3A%20%7B"region"%3A%20""%7D%2C%20"1101"%3A%20%7B"__time_range"%3A%20"2014-01-01%20%3A%202014-01-02"%7D%7D 1. user can change dashboard filters, or make change in Dashboard Properties, and save dashboard. Then user will assume dashboard default filters are changed and saved. 1. If user reload dashboard and test, they want see the new default filters, but because dashboard is loaded with `preselect_filters` in the url, dashboard's metadata is overwritten by old request parameter. So they can not see the new change. We added "preselect_filters" in the dashboard url long time ago, at that time we didn't load and parse all dashboard metadata. Right now we got same information from dashboard metadata, I think we don't need to append in the dashboard url (since it might cause problem after dashboard is updated). We will still keep the functionality that parse "preselect_filters" in dashboard, and url parameter can overwrite dashboard metadata. If users want to dynamic generate dashboard link with preselect_filters, this behavior won't be changed. ### TEST PLAN CI and manual test ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
