nytai commented on pull request #11618: URL: https://github.com/apache/incubator-superset/pull/11618#issuecomment-726342070
Yes, this LGTM. As far as per-field error handling, this is an issue for all our create/edit modals. We really should have a form state with per-field errors so that we can display them inline on the form instead of in toasts. That's beyond the scope of this PR, but it is an issue with these new react crud views/forms. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
