nytai commented on a change in pull request #11683:
URL:
https://github.com/apache/incubator-superset/pull/11683#discussion_r522547378
##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -45,13 +47,14 @@ const createFetchResourceMethod = (method: string) => (
const { json = {} } = await SupersetClient.get({
endpoint: `${resourceEndpoint}?q=${queryParams}`,
});
-
- return json?.result?.map(
+ const data = json?.result?.map(
({ text: label, value }: { text: string; value: any }) => ({
label,
value,
}),
);
+
+ return options.concat(data);
Review comment:
Actually, nvm. Looks like these results are merged in with the existing
ones and get properly deduped. 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
