nytai commented on a change in pull request #11687:
URL:
https://github.com/apache/incubator-superset/pull/11687#discussion_r522741111
##########
File path: superset-frontend/src/views/CRUD/dashboard/DashboardCard.tsx
##########
@@ -67,13 +67,11 @@ function DashboardCard({
const menu = (
<Menu>
- {canEdit && openDashboardEditModal && (
+ {canEdit && handleDashboardEdit && (
<Menu.Item
role="button"
tabIndex={0}
- onClick={() =>
- openDashboardEditModal && openDashboardEditModal(dashboard)
- }
+ onClick={() => handleDashboardEdit && handleDashboardEdit(dashboard)}
Review comment:
I don't really support superset's gratuitous use of `target="_blank"`. I
usually have too many tabs open and don't need any more. We can convert them to
anchors though
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
