adam-stasiak commented on a change in pull request #11685:
URL:
https://github.com/apache/incubator-superset/pull/11685#discussion_r522844201
##########
File path:
superset-frontend/cypress-base/cypress/integration/dashboard/load.test.js
##########
@@ -43,14 +43,19 @@ describe('Dashboard load', () => {
slices.forEach(slice => {
const vizType = slice.form_data.viz_type;
const isLegacy = isLegacyChart(vizType);
- // TODO(villebro): enable V1 charts
if (isLegacy) {
const alias = `getJson_${slice.slice_id}`;
const formData = `{"slice_id":${slice.slice_id}}`;
const route = `/superset/explore_json/?*${formData}*`;
cy.route('POST', `${route}`).as(alias);
aliases.push(`@${alias}`);
}
+ else {
+ const alias = `getV1ChartJson`;
+ const route = `/api/v1/chart/data?*`;
+ cy.route('POST', `${route}`).as(alias);
+ aliases.push(`@${alias}`);
+ }
Review comment:
If it is always the same and i put * at the end of the route -> I see
benefit in suggested solution :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
