junlincc removed a comment on issue #11659:
URL:
https://github.com/apache/incubator-superset/issues/11659#issuecomment-727011014
> @mihir174 thanks for the updates! This looks good. Any reason to give the
query snippet a gray background? Currently it kind of blends too well with the
page background. Would also be curious to see how the card looks like when the
title is very long.
>
> I like the new icons for charts in the Recents section! Much more
distinguishable than the current icons.
>
> Looking at this page more, I'd like to make a couple of more suggestions
for your consideration: @junlincc @mistercrunch
>
> 1. Should we move the Charts section above Saved Queries, or even
Dashboards?
> 2. For Superset instances that do not have thumbnails enabled, maybe we
could change the thumbnail cards to use the same style as the Recents cards.
> 3. The Recents cards uses "Last Edited: {absolute timestamp}" but the
thumbnail cards says "Last modified {relative time}":
>
> 1. Should we have some consistency here?
> 2. Should the recently viewed cards use "Last viewed"?
> 4. In the Recents section, even with the icons, it's still a little hard
to tell whether a card represents a dashboard or a chart. I wonder if we can
change the whole section to be only about "Recently viewed", and use the tabs
to filter by entity types.
1. +1 on moving charts above saved queries, but i know some companies are
heavy users of SQL lab and they may want to prioritize saved queries info.
2. we can certainly consider it, given enable thumbnails is such a pain....
3. totally agree to keep the consistency. i voiced that before as well
4. need design input. @mihir174
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
