kgabryje commented on a change in pull request #11640:
URL:
https://github.com/apache/incubator-superset/pull/11640#discussion_r523986938
##########
File path: superset-frontend/src/explore/components/SaveModal.jsx
##########
@@ -109,19 +110,31 @@ class SaveModal extends React.Component {
sliceParams.save_to_dashboard_id = this.state.saveToDashboardId;
sliceParams.new_dashboard_name = this.state.newDashboardName;
- this.props.actions
- .saveSlice(this.props.form_data, sliceParams)
- .then(({ data }) => {
- if (data.dashboard_id === null) {
- sessionStorage.removeItem(SK_DASHBOARD_ID);
- } else {
- sessionStorage.setItem(SK_DASHBOARD_ID, data.dashboard_id);
- }
- // Go to new slice url or dashboard url
- const url = gotodash ? data.dashboard_url : data.slice.slice_url;
- window.location.assign(url);
+ if (slice.slice_updated) {
+ const payload = {
+ description: slice.description || null,
+ cache_timeout: slice.cache_timeout || null,
+ owners: slice.owners || null,
+ };
+ await SupersetClient.put({
Review comment:
I see. In that case, I'm going to change the status of this PR to draft
and wait for merge of https://github.com/apache/incubator-superset/pull/11667.
Then I'll remove the conditional requests in Edit properties modal and rename
"Save" to "Ok" in the same modal.
However, that doesn't solve @graceguo-supercat's concerns regarding the flow
of saving edited data through SaveModal. Or do we have a consensus in that
matter?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
