ktmud commented on a change in pull request #11704:
URL: 
https://github.com/apache/incubator-superset/pull/11704#discussion_r524936784



##########
File path: UPDATING.md
##########
@@ -36,7 +38,7 @@ assists people when migrating to a new version.
   and requires more work. You can easily turn on the languages you want
   to expose in your environment in superset_config.py
 
-* [11172](https://github.com/apache/incubator-superset/pull/11172): Breaking 
change: SQL templating is turned off be default. To turn it on set 
`ENABLE_TEMPLATE_PROCESSING` to True on `DEFAULT_FEATURE_FLAGS`
+* [11172](https://github.com/apache/incubator-superset/pull/11172): Breaking 
change: SQL templating is turned off be default. To turn it on set 
`ENABLE_TEMPLATE_PROCESSING` to True in `FEATURE_FLAGS`

Review comment:
       Maybe we should prevent `DEFAULT_FEATURE_FLAGS` from being overridden by 
custom config files/modules.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to