mistercrunch commented on a change in pull request #11704:
URL:
https://github.com/apache/incubator-superset/pull/11704#discussion_r525383699
##########
File path: superset/jinja_context.py
##########
@@ -266,6 +338,15 @@ class PrestoTemplateProcessor(BaseTemplateProcessor):
engine = "presto"
+ def set_context(self, **kwargs: Any) -> None:
+ super().set_context(**kwargs)
+ self._context[self.engine] = {
Review comment:
Yes. The goal was to have the exposed function have the database context
(so that they can talk to them without having the user having to specify the
`database_id`), but being clear on which method is being used. We have to keep
it that way if we care about backwards compatibility.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
