villebro commented on a change in pull request #11731:
URL:
https://github.com/apache/incubator-superset/pull/11731#discussion_r525604532
##########
File path: superset/connectors/base/models.py
##########
@@ -128,10 +128,8 @@ def slices(self) -> RelationshipProperty:
),
)
- # placeholder for a relationship to a derivative of BaseColumn
- columns: List[Any] = []
- # placeholder for a relationship to a derivative of BaseMetric
- metrics: List[Any] = []
+ columns: List["BaseColumn"] = []
+ metrics: List["BaseMetric"] = []
Review comment:
Bycatch: not sure why these weren't typed (did the same for SQLA and
Druid)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
