eschutho opened a new pull request #11732:
URL: https://github.com/apache/incubator-superset/pull/11732


   ### SUMMARY
   Per @ktmud's findings from 
https://github.com/apache/incubator-superset/pull/11289 there is some jumpy 
behavior if the 
   placeholder is very wide. It looks like react-select is setting a dynamic 
width on the input based on the length of the placeholder. Then there's an 
overflow: hidden to cut down the size to fit the component. Together with the 
existing flex-box styling, it forced the element to go off the element to the 
left. The width element is somewhat fighting with the flex-box functionality, 
so I overwrote it and relied solely on flexbox to determine the width of the 
elements and let it adjust more gracefully. I'm not 100% familiar with the 
react-select library, so there may be more tooling hid somewhere that we can 
utilize. 
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   
   ### TEST PLAN
   tested visuallly in storybook
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [x] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to