betodealmeida commented on a change in pull request #11743:
URL:
https://github.com/apache/incubator-superset/pull/11743#discussion_r526500374
##########
File path: superset/models/helpers.py
##########
@@ -87,14 +87,6 @@ class ImportExportMixin:
__mapper__: Mapper
- @classmethod
- def _parent_foreign_key_mappings(cls) -> Dict[str, str]:
- """Get a mapping of foreign name to the local name of foreign keys"""
- parent_rel = cls.__mapper__.relationships.get(cls.export_parent)
- if parent_rel:
- return {l.name: r.name for (l, r) in parent_rel.local_remote_pairs}
- return {}
-
Review comment:
This is not being used anywhere, seems like the result of a bad merge
because we have an identical class method called `parent_foreign_key_mappings`
(no leading underscore).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
