robdiciuccio commented on pull request #11730: URL: https://github.com/apache/incubator-superset/pull/11730#issuecomment-730062102
My suspicion as to why Cypress is not running on this build is that the the new [pull_request_target](https://docs.github.com/en/free-pro-team@latest/actions/reference/events-that-trigger-workflows#pull_request_target) event "runs in the context of the base repository of the pull request, rather than in the merge commit" and "only workflows defined in the commit on the base repository are run." So, theoretically, the updated workflow will run once merged to master. If it doesn't behave as expected, we can revert and try something else. This also makes it more difficult to Cypress workflow changes in PRs, but it seems to be the only workaround for the secrets sharing limitation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
