eschutho commented on pull request #11732:
URL: 
https://github.com/apache/incubator-superset/pull/11732#issuecomment-730065692


   Ok, I was able to find a way to pass styles into react-select for the input 
element. The reason I think it needs to be contained to the parent element is 
for long placeholders. Here's an example:
   <img width="509" alt="_DEV__Region_Filter" 
src="https://user-images.githubusercontent.com/5186919/99609040-f9214200-29c3-11eb-9e0b-46bbed62b72b.png";>
   
   I updated the OnPasteSelect as mentioned above by removing the wrapper so 
that we could continue to utilize the flex box styles, and it appears to work, 
but lmk if there's maybe some functionality that I didn't test. 
   
   Here are videos of three places that I tested. Some of us are looking into 
automated visual testing tools as well!
   
![region_filter](https://user-images.githubusercontent.com/5186919/99609214-4f8e8080-29c4-11eb-8363-078af6180bb9.gif)
   
![chart_filter](https://user-images.githubusercontent.com/5186919/99609220-52897100-29c4-11eb-9325-978ff47ea39c.gif)
   
![storybook](https://user-images.githubusercontent.com/5186919/99609232-561cf800-29c4-11eb-99c7-a4d9c1bb79f5.gif)
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to