[GitHub] [incubator-superset] junlincc edited a comment on pull request #11615: fix(viz treemap): Cannot nest more than three levels

[GitBox]

junlincc edited a comment on pull request #11615:
URL: 
https://github.com/apache/incubator-superset/pull/11615#issuecomment-730559444


   <img width="1269" alt="Screen Shot 2020-11-19 at 10 22 57 AM" 
src="https://user-images.githubusercontent.com/67837651/99707880-e9503f00-2a51-11eb-8a6a-66682c0e24e0.png";>
   Thank you, Chaoyi @newtoncy for the fix. This is what I'm seeing nested 3 
layers on tree map, we need to either truncate the group labels or not show 
labels on chart + show on hover when the grid is small, would you mind making 
the changes? 
   
   Expected behavior:
   <img width="578" alt="Screen Shot 2020-11-19 at 11 24 54 AM" 
src="https://user-images.githubusercontent.com/67837651/99713992-dd687b00-2a59-11eb-8469-13e2d466c680.png";>
   
   consider Tableau's treatment below
   <img width="675" alt="Treemap-many-dim-members" 
src="https://user-images.githubusercontent.com/67837651/99708225-6d0a2b80-2a52-11eb-88ad-2026b992d2b4.png";>
   
   Please don't merge yet until cosmetic issues are addressed🙏 @villebro 
@mistercrunch 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@superset.apache.org
For additional commands, e-mail: notifications-h...@superset.apache.org