betodealmeida commented on a change in pull request #11755:
URL:
https://github.com/apache/incubator-superset/pull/11755#discussion_r527248619
##########
File path: superset-frontend/src/SqlLab/components/ResultSet.tsx
##########
@@ -95,11 +104,30 @@ export default class ResultSet extends React.PureComponent<
this.toggleExploreResultsButton = this.toggleExploreResultsButton.bind(
this,
);
+ this.handleSaveInDataset = this.handleSaveInDataset.bind(this);
+ this.handleHideSaveModal = this.handleHideSaveModal.bind(this);
+ this.handleDatasetNameChange = this.handleDatasetNameChange.bind(this);
+ this.handleSaveDatasetRadioBtnState =
this.handleSaveDatasetRadioBtnState.bind(this);
+ this.handleOverwriteCancel = this.handleOverwriteCancel.bind(this);
+ this.handleOverwriteDataset = this.handleOverwriteDataset.bind(this);
+ this.handleOverwriteDatasetOption =
this.handleOverwriteDatasetOption.bind(this);
}
componentDidMount() {
// only do this the first time the component is rendered/mounted
this.reRunQueryIfSessionTimeoutErrorOnMount();
+
+ // Todo: figure out how to get user information to properly query datasets
they own
Review comment:
I think if you query the API on `/api/v1/dataset/` it should return only
datasets owned by the user (cc: @dpgaspar).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
