bkyryliuk commented on pull request #11711: URL: https://github.com/apache/incubator-superset/pull/11711#issuecomment-731402908
> > left couple nits, but overall looks really good > > definitely needs unit tests, your call if they should be added in this PR or later > > Thanks a lot for revamping alerts! > > Thanks a lot for the review! note that this PR already has unit tests damn, that's my bad - need to keep attention to the collapsed github files :)  ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
