LonelyLok commented on issue #8236:
URL: 
https://github.com/apache/incubator-superset/issues/8236#issuecomment-731707615


   hi all (I am @henry145145 btw, this is my second account), this is probably 
outdated but here is an example pull request of how I glue part of the pull 
request https://github.com/apache/incubator-superset/issues/3416 into branch 
**0.38**
   
   Notice that the example i am using is for **Table chart** and I did not glue 
the **row configuration**. However, I do believe that once you understand the 
concept, you can glue it into pivot table chart too. 
   
   Here is the pull request: 
https://github.com/LonelyLok/incubator-superset/pull/1
   
   The pull request show a lot of file changes so here are some key points:
   - highly recommend read 
https://superset.apache.org/docs/installation/building-custom-viz-plugins to 
understand how to use custom ui plug in.
   - I grabbed the original table plug in from 
https://github.com/apache-superset/superset-ui/tree/master/plugins/plugin-chart-table
 as a template for my "custom" plugin (v0.15.13)
   - put those files in a new directory 
`superset-frontend/src/visualizations/CTable'
   - make changes on the 
`superset-frontend/src/visualizations/presets/MainPreset.js` to use the custom 
plugin
   - add `superset-frontend/src/explore/components/controls/ColumnControl.jsx`
   - edit files under CTable directory such as `controlPanel.js` and 
`TableChart.js`
   
   Also, my intention of this pull request is just a "beginning guide" of how 
to implement https://github.com/apache/incubator-superset/issues/3416 into 0.38 
branch since it seem like my last two explanation above was outdated and the 
mapping between old and new superset directory/files are little bit confusing. 
   
   I did zero testing on this so there might be some bug so use it at your own 
risk.
   
   Here is a gif of what it look like (it took some times to load the chart 
when I recording it):
   ![Alt 
Text](https://raw.githubusercontent.com/LonelyLok/incubator-superset/test-0.38-v2/img/test.gif)
   
   I hope this help. I do hope the conditional formatting feature will 
eventually land on the official Superset.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to