rusackas commented on a change in pull request #11779:
URL:
https://github.com/apache/incubator-superset/pull/11779#discussion_r529121382
##########
File path:
superset-frontend/src/dashboard/components/filterscope/FilterScopeModal.jsx
##########
@@ -26,6 +27,13 @@ const propTypes = {
triggerNode: PropTypes.node.isRequired,
};
+const FilterScopeModalBody = styled.div`
+ padding: ${({ theme }) => theme.gridUnit * 2}px
+ ${({ theme }) => theme.gridUnit * 2}px
+ ${({ theme }) => theme.gridUnit * 3}px
+ ${({ theme }) => theme.gridUnit * 2}px;
Review comment:
Just a nit, but I've been wondering about cases like this... it's fine
as-is, but I've been wondering about readability. There might be a more
short-hand way, with a template string within a template string. At the very
least, in cases like this, you could just say
```
padding: ${({ theme }) => theme.gridUnit * 2}px;
padding-bottom: padding: ${({ theme }) => theme.gridUnit * 3}px;
```
¯\\\_(ツ)_/¯
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
