dpgaspar commented on a change in pull request #11711: URL: https://github.com/apache/incubator-superset/pull/11711#discussion_r529302972
########## File path: superset/reports/notifications/email.py ########## @@ -0,0 +1,94 @@ +# -*- coding: utf-8 -*- +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +import json +import logging +from dataclasses import dataclass +from email.utils import make_msgid, parseaddr +from typing import Dict + +from flask_babel import gettext as __ + +from superset import app +from superset.models.reports import ReportRecipientType +from superset.reports.notifications.base import BaseNotification +from superset.utils.core import send_email_smtp + +logger = logging.getLogger(__name__) + + +@dataclass +class EmailContent: + body: str + images: Dict[str, bytes] + + +class EmailNotification(BaseNotification): # pylint: disable=too-few-public-methods + """ + Sends an email notification for a report recipient + """ + + type = ReportRecipientType.EMAIL + + @staticmethod + def _get_smtp_domain() -> str: + return parseaddr(app.config["SMTP_MAIL_FROM"])[1].split("@")[1] + + def _get_content(self) -> EmailContent: + # Get the domain from the 'From' address .. + # and make a message id without the < > in the ends + domain = self._get_smtp_domain() + msgid = make_msgid(domain)[1:-1] + + image = {msgid: self._content.screenshot.image} + body = __( + """ + <b><a href="%(url)s">Explore in Superset</a></b><p></p> + <img src="cid:%(msgid)s"> + """, + url=self._content.screenshot.url, + msgid=msgid, + ) + return EmailContent(body=body, images=image) + + def _get_subject(self) -> str: + return __( + "%(prefix)s %(title)s", + prefix=app.config["EMAIL_REPORTS_SUBJECT_PREFIX"], + title=self._content.name, + ) + + def _get_to(self) -> str: + return json.loads(self._recipient.recipient_config_json)["target"] + + def send(self) -> None: + subject = self._get_subject() + content = self._get_content() + to = self._get_to() + send_email_smtp( + to, Review comment: Right now it's somewhat simplistic, each `recipients` target will trigger an email, if the `target` contains multiple SMTP addresses then only one email is sent. I would vote for optimising on the next phase ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
