ktmud commented on a change in pull request #11678:
URL:
https://github.com/apache/incubator-superset/pull/11678#discussion_r529754080
##########
File path: superset-frontend/src/views/CRUD/utils.tsx
##########
@@ -261,22 +261,31 @@ export function handleDashboardDelete(
);
}
+export function shortenSQL(sql: string, maxLines: number) {
+ let lines: string[] = sql.split('\n');
+ if (lines.length >= maxLines) {
+ lines = lines.slice(0, maxLines);
+ lines.push('...');
Review comment:
Personally I'd say let it wrap and just get rid of "...", basically your
#3.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
