ktmud commented on a change in pull request #11779:
URL:
https://github.com/apache/incubator-superset/pull/11779#discussion_r529780850
##########
File path:
superset-frontend/src/dashboard/components/filterscope/FilterScopeModal.jsx
##########
@@ -26,6 +27,13 @@ const propTypes = {
triggerNode: PropTypes.node.isRequired,
};
+const FilterScopeModalBody = styled.div`
+ padding: ${({ theme }) => theme.gridUnit * 2}px
+ ${({ theme }) => theme.gridUnit * 2}px
+ ${({ theme }) => theme.gridUnit * 3}px
+ ${({ theme }) => theme.gridUnit * 2}px;
Review comment:
No, you don't need `${gridUnit * 2}px`. What I shared is working code.
This is the same as passing inline style objects to React components:
```
<div style={{ padding: 15 }} />
```
The default units for some CSS properties are `px`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
