ktmud commented on a change in pull request #11418:
URL:
https://github.com/apache/incubator-superset/pull/11418#discussion_r529796162
##########
File path: superset/utils/core.py
##########
@@ -1358,9 +1358,9 @@ def get_since_until(
# default matched case
since_and_until.append(f"DATETIME('{part}')")
- logger.debug(f"Raw [time_range] text: {time_range}")
- logger.debug(f"[since] datetime_eval text: {since_and_until[0]}")
- logger.debug(f"[until] datetime_eval text: {since_and_until[1]}")
+ logger.debug("Raw [time_range] text: %s", time_range)
+ logger.debug("[since] datetime_eval text: %s", since_and_until[0])
+ logger.debug("[until] datetime_eval text: %s", since_and_until[1])
Review comment:
got it. didn't notice this is for `logging`.
##########
File path: superset/utils/core.py
##########
@@ -1358,9 +1358,9 @@ def get_since_until(
# default matched case
since_and_until.append(f"DATETIME('{part}')")
- logger.debug(f"Raw [time_range] text: {time_range}")
- logger.debug(f"[since] datetime_eval text: {since_and_until[0]}")
- logger.debug(f"[until] datetime_eval text: {since_and_until[1]}")
+ logger.debug("Raw [time_range] text: %s", time_range)
+ logger.debug("[since] datetime_eval text: %s", since_and_until[0])
+ logger.debug("[until] datetime_eval text: %s", since_and_until[1])
Review comment:
got it. didn't notice this was for `logging`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
