benceorlai commented on pull request #11781:
URL: 
https://github.com/apache/incubator-superset/pull/11781#issuecomment-733186632


   > > When the enter through Data >Datasets>Edit, the padlock should not 
apply. In the latter case, the user's intent is clear, to edit the dataset, and 
the padlock can get annoying quickly.
   > 
   > Hi @benceorlai thanks for the feedback, but i could not agree with this 
point. When a dataset is large and shared by multiple users/teams, many time 
you want to _**check and make sure**_ the definition of its metrics and 
calculated columns before actually make chart out of it.
   > 
   > In the explore view context, i would believe the majority of use cases for 
Datasets > Edit, is to see dataset details instead of actual change it.
   
   That's an interesting point you raise, and then the solution could be the 
introduction of a new "View" action, in addition to "Edit". My approach to this 
is to align the user intent and the UX, and I think the "Edit" term is very 
unambiguous to know what the user should expect. It seems that View (=see 
details), Edit (=make global changes) and Copy (=make 1-off changes) options 
would cover every possible intent.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to