hughhhh commented on a change in pull request #11751: URL: https://github.com/apache/incubator-superset/pull/11751#discussion_r530051942
########## File path: superset/dashboards/commands/importers/dispatcher.py ########## @@ -0,0 +1,73 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +import logging +from typing import Any, Dict + +from marshmallow.exceptions import ValidationError + +from superset.commands.base import BaseCommand +from superset.commands.exceptions import CommandInvalidError +from superset.commands.importers.exceptions import IncorrectVersionError +from superset.dashboards.commands.importers import v0, v1 + +logger = logging.getLogger(__name__) + +# list of different import formats supported; v0 should be last because +# the files are not versioned +command_versions = [ + v1.ImportDashboardsCommand, + v0.ImportDashboardsCommand, +] + + +class ImportDashboardsCommand(BaseCommand): + """ + Import dashboards. + + This command dispatches the import to different versions of the command + until it finds one that matches. + """ + + # pylint: disable=unused-argument + def __init__(self, contents: Dict[str, str], *args: Any, **kwargs: Any): + self.contents = contents + + def run(self) -> None: + # iterate over all commands until we find a version that can + # handle the contents + for version in command_versions: + command = version(self.contents) + try: + command.run() + return + except IncorrectVersionError: + # file is not handled by command, skip + pass Review comment: nit: add logger.info stating we are skipping this file ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
