villebro commented on a change in pull request #11801:
URL:
https://github.com/apache/incubator-superset/pull/11801#discussion_r530322842
##########
File path: superset/charts/commands/exceptions.py
##########
@@ -78,13 +78,21 @@ class ChartDeleteFailedError(DeleteFailedError):
message = _("Chart could not be deleted.")
+class ChartDeleteFailedReportsExistError(ChartDeleteFailedError):
+ message = _("There are associated alerts or reports associated")
Review comment:
The word "associated" is used twice here. Would "The chart has
associated alerts or reports" make sense?
##########
File path: superset/dashboards/commands/exceptions.py
##########
@@ -53,6 +53,10 @@ class DashboardBulkDeleteFailedError(CreateFailedError):
message = _("Dashboards could not be deleted.")
+class
DashboardBulkDeleteFailedReportsExistError(DashboardBulkDeleteFailedError):
+ message = _("There are associated alerts or reports associated")
Review comment:
Same here
##########
File path: superset/charts/commands/exceptions.py
##########
@@ -78,13 +78,21 @@ class ChartDeleteFailedError(DeleteFailedError):
message = _("Chart could not be deleted.")
+class ChartDeleteFailedReportsExistError(ChartDeleteFailedError):
+ message = _("There are associated alerts or reports associated")
+
+
class ChartForbiddenError(ForbiddenError):
message = _("Changing this chart is forbidden")
-class ChartBulkDeleteFailedError(CreateFailedError):
+class ChartBulkDeleteFailedError(DeleteFailedError):
message = _("Charts could not be deleted.")
+class ChartBulkDeleteFailedReportsExistError(ChartBulkDeleteFailedError):
+ message = _("There are associated alerts or reports associated")
Review comment:
Same here
##########
File path: superset/dashboards/commands/exceptions.py
##########
@@ -61,6 +65,10 @@ class DashboardDeleteFailedError(DeleteFailedError):
message = _("Dashboard could not be deleted.")
+class DashboardDeleteFailedReportsExistError(DashboardDeleteFailedError):
+ message = _("There are associated alerts or reports associated")
Review comment:
Same here
##########
File path: superset/databases/commands/exceptions.py
##########
@@ -113,6 +113,10 @@ class DatabaseDeleteFailedError(DeleteFailedError):
message = _("Database could not be deleted.")
+class DatabaseDeleteFailedReportsExistError(DatabaseDeleteFailedError):
+ message = _("There are associated alerts or reports associated")
Review comment:
same here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
