[GitHub] [incubator-superset] agatapst opened a new pull request #11811: fix: Adding, removing & editing annotations

Wed, 25 Nov 2020 06:06:50 -0800 


agatapst opened a new pull request #11811:
URL: https://github.com/apache/incubator-superset/pull/11811


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   This fix covers adding, editing and removing annotation layers. 
   It closes #11782 where everything was explained with details.  
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   **Before:**
   **adding annotation**
   
![before_adding_annotations](https://user-images.githubusercontent.com/47450693/100233625-4b191900-2f2a-11eb-9ac6-6f5e0fc3c744.gif)
   
   **removing annotation**
   
![before_removing_annotations](https://user-images.githubusercontent.com/47450693/100233657-53715400-2f2a-11eb-8308-cffbc2643b36.gif)
   
   **After:
   adding annotation**
   
![adding_annotations](https://user-images.githubusercontent.com/47450693/100232570-cf6a9c80-2f28-11eb-9f70-a534ff3a9a6a.gif)
   
   **emoving annotation**
   
![editing_removing_annotations](https://user-images.githubusercontent.com/47450693/100232661-edd09800-2f28-11eb-9076-3b6ea47f2367.gif)
   
   ### TEST PLAN
   Please verify manually. Steps to recreate issue are described on the Issue 
#11782 page.
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [x] Has associated issue: Fixes #11782 
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to