rusackas commented on pull request #11778: URL: https://github.com/apache/incubator-superset/pull/11778#issuecomment-733870392
> @adam-stasiak I fixed the menu not closing on Explore view. Can you test it again? > By the way, in DisplayQueryButton we still use dropdown trigger from react-bootstrap and it didn't need any timeout gimmicks like the dropdown trigger from Antd... which is a bit worrying if we plan to migrate dropdown triggers as well. I do think we should migrate away from that r-b dropdown trigger, but this is disheartening to hear that it might be painful. Maybe we get that one toward the tail end so at least if it's painful, there's an `npm uninstall` celebration at the end of the tunnel :D ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
