nytai edited a comment on issue #11688: URL: https://github.com/apache/incubator-superset/issues/11688#issuecomment-733939266
I think it's quite normal for a codebase that's >5 years old to have a lot of accumulated patterns, especially one with as many contributors as superset. Sometimes introducing a new pattern is conflated with refactoring out all the old patterns. I don't think anyone is suggesting migrating all enzyme tests to use RTL (or whatever the latest flavor is at the moment). React has been making quite a few changes to their API, I don't think we should limiting our use there. Similarly, enzyme has fallen behind the curve, I don't think we should continue to fight with the lib to get it to work with newer portions of the react api. I have found myself fighting with enzyme, to get what should be simple tests to pass, more often than not (see how ubiquitous [this util](https://github.com/apache/incubator-superset/blob/9c69679e14c2fa2b031c5c22b5cb95b640925176/superset-frontend/spec/helpers/waitForComponentToPaint.ts#L29) has become in test files). Therefore, consider this a big # **+1** from me as I suspect writing tests will become far more enjoyable with RTL in the toolbox. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
