rusackas commented on a change in pull request #11678:
URL:
https://github.com/apache/incubator-superset/pull/11678#discussion_r530662777
##########
File path: superset-frontend/src/views/CRUD/welcome/SavedQueries.tsx
##########
@@ -57,19 +64,51 @@ interface SavedQueriesProps {
mine: Array<Query>;
}
+export const CardStyles = styled.div`
+ cursor: pointer;
+ a {
+ text-decoration: none;
+ }
+ .ant-card-cover {
+ border-bottom: 1px solid ${({ theme }) => theme.colors.grayscale.light2};
+ & > div {
+ height: 171px;
Review comment:
This can be an experiment for another PR, but if this card is basically
a text box, we may be able to base its height on the number of lines set
elsewhere in the JS. That is, if `line-height` is pulled from the Theme
variables, the height could be `numLines * lineHeight`. Anyway, something to
fiddle with to make this a little more dynamic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
