graceguo-supercat edited a comment on pull request #11781: URL: https://github.com/apache/incubator-superset/pull/11781#issuecomment-733974901
The extra feature flag `DISABLE_DATASET_SOURCE_EDIT`, only meant to disable other user change dataset, but allow different teams to enrich dataset. Additional Padlock will make add/modify metric and columns more troublesome, which happens very often in airbnb. @ktmud and @Steejay I think for this PR we should follow the agreement from last meetup: https://github.com/apache/incubator-superset/issues/11478#issuecomment-720125272 If you have more options, bring up to meetup (or SIP) and get feedback from more audience. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
