ktmud commented on a change in pull request #11816:
URL:
https://github.com/apache/incubator-superset/pull/11816#discussion_r530700622
##########
File path: superset-frontend/src/components/Menu/Menu.tsx
##########
@@ -195,8 +196,15 @@ export function Menu({
{!navbarRight.user_is_anonymous && [
<DropdownMenu.Divider key="user-divider" />,
<DropdownMenu.ItemGroup key="user-section" title={t('User')}>
- <DropdownMenu.Item key="profile">
- <a href={navbarRight.user_info_url}>{t('Profile')}</a>
+ {navbarRight.user_profile_url && (
+ <DropdownMenu.Item key="profile">
+ <a href={navbarRight.user_profile_url}>
+ {t('Profile')}
+ </a>
+ </DropdownMenu.Item>
+ )}
+ <DropdownMenu.Item key="edit">
+ <a href={navbarRight.user_info_url}>{t('Edit')}</a>
Review comment:
For some cases, the default user info url doesn't really allow users to
edit their profile. Maybe we should add a permission check here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
