ktmud commented on pull request #11714: URL: https://github.com/apache/incubator-superset/pull/11714#issuecomment-734009387
Hmm, sorry for being late to the party. But I think `path_no_int` should've been `path_no_param` because ideally you'd want to remove all parameters (e.g. slug) even if they are not int. Also, it would be more robust to get that path from the `@expose` decorator (it adds a private `_urls[]` prop to the wrapped route handler) instead of manually cleaning up the string. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
