kkucharc opened a new pull request #11830:
URL: https://github.com/apache/incubator-superset/pull/11830


   ### SUMMARY
   Updating chart's properties was removing all existing connection to 
dashboards where chart was added. Right now it is checked if list of chart's 
dashboards is updated as well.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   Before:
   ![Screenshot 2020-11-26 at 20 03 
08](https://user-images.githubusercontent.com/2536609/100385314-8dbe1c80-3022-11eb-9fac-64f1ec5432ef.png)
   
   After:
   ![Screenshot 2020-11-26 at 19 55 
42](https://user-images.githubusercontent.com/2536609/100385320-931b6700-3022-11eb-96a2-2901c8937d9a.png)
 
   It's possible to change title into:
   ![Screenshot 2020-11-26 at 20 02 
20](https://user-images.githubusercontent.com/2536609/100385335-99a9de80-3022-11eb-8e18-fc3d0175dcc7.png)
   
   ### TEST PLAN
   1. Add chart to a dashboard and save
   2. Go to chart's details and click burger -> Edit properties
   3. Change something ex. title
   4. Go back to the dashboard and refresh, chart should be there with new title
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   Fixes: #10528
   - [ ] Has associated issue: 
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to