etr2460 commented on a change in pull request #11778:
URL:
https://github.com/apache/incubator-superset/pull/11778#discussion_r532359446
##########
File path: superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
##########
@@ -123,6 +125,9 @@ class SliceHeaderControls extends React.PureComponent {
}
handleMenuClick({ key, domEvent }) {
+ const menu = document.querySelector(
Review comment:
seems like you can if you wrap the case clause in a block:
https://eslint.org/docs/rules/no-case-declarations
I think this is still preferable, as the const isn't required outside of the
case clause
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
