graceguo-supercat commented on a change in pull request #11781:
URL:
https://github.com/apache/incubator-superset/pull/11781#discussion_r533797138
##########
File path:
superset-frontend/spec/javascripts/datasource/DatasourceEditor_spec.jsx
##########
@@ -142,4 +147,65 @@ describe('DatasourceEditor', () => {
wrapper.find(Field).find({ fieldKey: 'fetch_values_predicate'
}).exists(),
).toBe(true);
});
+
+ describe('enable edit Source tab', () => {
+ beforeAll(() => {
+ isFeatureEnabledMock = jest
+ .spyOn(featureFlags, 'isFeatureEnabled')
+ .mockImplementation(
+ feature => feature === 'ENABLE_DATASET_SOURCE_EDIT',
Review comment:
fixed. The logic here is **_if feature is not enabled_**, though used
the wrong feature name, this feature "disable edit", is not enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
