graceguo-supercat commented on a change in pull request #11808:
URL:
https://github.com/apache/incubator-superset/pull/11808#discussion_r533811532
##########
File path: superset-frontend/src/dashboard/components/gridComponents/Tab.jsx
##########
@@ -53,6 +53,11 @@ const propTypes = {
setDirectPathToChild: PropTypes.func.isRequired,
};
+const StyledTab = styled.div`
+ background-color: ${({ theme }) => theme.colors.grayscale.light4};
+ padding: ${({ theme }) => theme.gridUnit * 4}px;
Review comment:
the fix padding will break the 12 columns grid in the dashboard. please
test it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
