rusackas commented on a change in pull request #11847:
URL:
https://github.com/apache/incubator-superset/pull/11847#discussion_r533933273
##########
File path: superset-frontend/src/explore/components/DisplayQueryButton.jsx
##########
@@ -75,6 +75,24 @@ const CopyButton = styled(Button)`
&& {
margin-left: ${({ theme }) => theme.gridUnit * 2}px;
}
+
+ i {
+ padding: 0;
+ }
+`;
+
+const CopyButtonViewQuery = styled(Button)`
+ padding: ${({ theme }) => theme.gridUnit / 2}px
Review comment:
Does it look good (or even better?) if it's just 2 gridUnits of padding
all the way around? Super minor detail, but I'm trying to avoid fractional
gridUnits, in case we decide the gridUnit should be 5px, and we find ourselves
in weird half-pixel-land.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
