graceguo-supercat edited a comment on pull request #11808: URL: https://github.com/apache/incubator-superset/pull/11808#issuecomment-737520625
1) The problem `filter Scope show tabbed panel and those panel don't have names` should not be solved by add Tabs name. You can check current implementation of Filter Scope Editor. `Tabs` is not an item in the checkbox list. Also for all the existed dashboards, there is no `name` for TABS component. I do not think you should force user to add name attribute for TABS component. 3) you can not see the regression? Just create a new dashboard, and add 3/4/5/6 charts in a row... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
